Unpack the string values from the CL2_.* envs #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without doing it, it's impossible to easily override boolean param via env. E.g. if I do
```
--env=ENABLE_MY_FEATURE=false
```
The `false` will be treated as string and then in the config file the if statement like this:
```
{{if .ENABLE_MY_FEATURE}}
...
{{end}}
```
Will evaluate to true and will be executed, because "false" is non-empty string that evaluates to true :)
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
wojtek-t
reviewed
Mar 30, 2020
| @@ -240,11 +241,24 @@ func LoadCL2Envs() (map[string]interface{}, error) { | |||
| return nil, goerrors.Errorf("unparsable string in os.Eviron(): %v", keyValue) | |||
| } | |||
| key, value := split[0], split[1] | |||
| mapping[key] = value | |||
| mapping[key] = unpackStringValue(value) | |||
There was a problem hiding this comment.
Are you sure it won't break any existing test?
There was a problem hiding this comment.
I'm 99% sure as of now.
Currently, we only use this feature in two places: scheduler_throughput and access_tokens. Both are enabled in the presubmit so we'll know for 100% in ~30min
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without doing it, it's impossible to easily override boolean param via env. E.g. if I do
The 'false' will be treated as string, and then in the config file the if statement like this:
Will evaluate to true and will be executed, because "false" is non-empty string that evaluates to true :)